Fix boolean for $editnotice_base message existance check that was messed up in r80248.

Also switch to using === for '' and '-' comparison like Nikerabbit wanted.

diff --git a/includes/EditPage.php b/includes/EditPage.php
index 71d7357..2dda909 100644 (file)
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -400,7 +400,7 @@ class EditPage {
                        while ( count( $parts ) > 0 ) {
                                $editnotice_base .= '-'.array_shift( $parts );
                                $editnotice_base_msg = wfMessage( $editnotice_base )->inContentLanguage();
-                               if ( !$editnotice_base_msg->exists() ) {
+                               if ( $editnotice_base_msg->exists() ) {
                                        $wgOut->addWikiText( $editnotice_base_msg->plain()  );
                                }
                        }

diff --git a/includes/Message.php b/includes/Message.php
index 4e2e153..c0a33c9 100644 (file)
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -314,7 +314,7 @@ class Message {
         */
        public function isBlank() {
                $message = $this->fetchMessage();
-               return $message === false || $message == '';
+               return $message === false || $message === '';
        }
 
        /**
@@ -323,7 +323,7 @@ class Message {
         */
        public function isDisabled() {
                $message = $this->fetchMessage();
-               return $message === false || $message == '' || $message == '-';
+               return $message === false || $message === '' || $message === '-';
        }
 
        public static function rawParam( $value ) {