Pass along tagFilter to ContribsPager, it already expects it
authorMatthias Mullie <git@mullie.eu>
Mon, 17 Jun 2013 20:23:35 +0000 (22:23 +0200)
committerAlex Monk <krenair@gmail.com>
Tue, 18 Jun 2013 14:34:43 +0000 (14:34 +0000)
ContribsPager already has this below line:

    $this->tagFilter = isset( $options['tagfilter'] ) ? $options['tagfilter'] : false;

The reason the code already works fine is because, in ChangeTags.php, there's this fallback:

    if ( $filter_tag === false ) {
     $filter_tag = $wgRequest->getVal( 'tagfilter' );
    }

Which essentially boils down to the same result as passing along tagfilter, which in
SpecialContributions is read from $wgRequest, passed to ContribsPager, and (well, currently
not) passed to ChangeTags

Change-Id: I12c0336ae31c5524e41fa0087afe2ba104dc7d37

includes/specials/SpecialContributions.php

index 21becd6..2f37cb4 100644 (file)
@@ -175,6 +175,7 @@ class SpecialContributions extends SpecialPage {
                                'target' => $target,
                                'contribs' => $this->opts['contribs'],
                                'namespace' => $this->opts['namespace'],
+                               'tagfilter' => $this->opts['tagfilter'],
                                'year' => $this->opts['year'],
                                'month' => $this->opts['month'],
                                'deletedOnly' => $this->opts['deletedOnly'],