Fix for warning in ForeignAPIFile when no thumbnails

Remote audio files have no thumbnails, so this check in
ForeignAPIFile for thumbnails by iterating over the result
from FileBackend::getFileList() could throw a warning about
invalid input to foreach, as it may return null.

Change-Id: I07f37ed5a299e1a3c9a1e6bddcbc5582f99e5274

diff --git a/includes/filerepo/file/ForeignAPIFile.php b/includes/filerepo/file/ForeignAPIFile.php
index 8dcb289..2a40942 100644 (file)
--- a/includes/filerepo/file/ForeignAPIFile.php
+++ b/includes/filerepo/file/ForeignAPIFile.php
@@ -340,8 +340,10 @@ class ForeignAPIFile extends File {
                $iter = $this->repo->getBackend()->getFileList( [ 'dir' => $dir ] );
 
                $files = [];
-               foreach ( $iter as $file ) {
-                       $files[] = $file;
+               if ( $iter ) {
+                       foreach ( $iter as $file ) {
+                               $files[] = $file;
+                       }
                }
 
                return $files;