Avoid dumping big stack traces from unit tests.

Using assertFalse( $exception ) results in potentially very large stack
trace dumps, when $exception is an exception from deep inside MediaWiki.

Stack trace dumps include a dump of all parameters, resulting in console
output of (in my case) over 160 MB.

Change-Id: Ib78493d86531844a892586c071b2fa631ad765eb

diff --git a/tests/phpunit/includes/import/ImportLinkCacheIntegrationTest.php b/tests/phpunit/includes/import/ImportLinkCacheIntegrationTest.php
index bdb4831..076924c 100644 (file)
--- a/tests/phpunit/includes/import/ImportLinkCacheIntegrationTest.php
+++ b/tests/phpunit/includes/import/ImportLinkCacheIntegrationTest.php
@@ -89,20 +89,11 @@ class ImportLinkCacheIntegrationTest extends MediaWikiTestCase {
 
                $reporter->setContext( new RequestContext() );
                $reporter->open();
-               $exception = false;
 
-               try {
-                       $importer->doImport();
-               } catch ( Exception $e ) {
-                       $exception = $e;
-               }
+               $importer->doImport();
 
                $result = $reporter->close();
 
-               $this->assertFalse(
-                       $exception
-               );
-
                $this->assertTrue(
                        $result->isGood()
                );