Revert "Support changing icon variants on hover"
authorVolkerE <volker.e@wikimedia.org>
Wed, 6 Dec 2017 00:33:35 +0000 (00:33 +0000)
committerRoan Kattouw <roan.kattouw@gmail.com>
Wed, 6 Dec 2017 02:00:29 +0000 (18:00 -0800)
This reverts commit 46c62ff5f474c6fe7a409863058e81bb678229b2. After reconsidering menu item treatment under UI Standardization perspective, we don't need and shouldn't use such pattern.

Bug: T110051
Change-Id: I0e8b6035f516e6629010b4f18471445c8833156e

includes/resourceloader/ResourceLoaderOOUIImageModule.php

index ee87d8d..5c9e1d9 100644 (file)
@@ -98,11 +98,8 @@ class ResourceLoaderOOUIImageModule extends ResourceLoaderImageModule {
                // Extra selectors to allow using the same icons for old-style MediaWiki UI code
                if ( substr( $module, 0, 5 ) === 'icons' ) {
                        $definition['selectorWithoutVariant'] = '.oo-ui-icon-{name}, .mw-ui-icon-{name}:before';
-                       $definition['selectorWithVariant'] = '
-                               .oo-ui-image-{variant}.oo-ui-icon-{name}, .mw-ui-icon-{name}-{variant}:before,
-                               /* Hack for Flow, see T110051 */
-                               .mw-ui-hovericon:hover .mw-ui-icon-{name}-{variant}-hover:before,
-                               .mw-ui-hovericon.mw-ui-icon-{name}-{variant}-hover:hover:before';
+                       $definition['selectorWithVariant'] = '.oo-ui-image-{variant}.oo-ui-icon-{name}, ' .
+                               '.mw-ui-icon-{name}-{variant}:before';
                }
 
                // Fields from module definition silently override keys from JSON files