phpunit: Don't bother resetting unused global in UploadFromUrlTestSuite
authorTimo Tijhof <krinklemail@gmail.com>
Sat, 31 Aug 2019 14:00:29 +0000 (15:00 +0100)
committerTimo Tijhof <krinklemail@gmail.com>
Sat, 31 Aug 2019 14:01:18 +0000 (15:01 +0100)
messageMemc is not used for anything important. Should be removed
soon, but at least don't reset it in tests. If something new depends
on it, it should fail.

Bug: T189966
Change-Id: Id707db028e6eba03242fc9e1541d785a607d9be9

tests/phpunit/suites/UploadFromUrlTestSuite.php

index d340221..2784abd 100644 (file)
@@ -18,7 +18,7 @@ class UploadFromUrlTestSuite extends PHPUnit_Framework_TestSuite {
        }
 
        protected function setUp() {
-               global $IP, $messageMemc, $wgMemc, $wgUser, $wgLang, $wgOut, $wgRequest, $wgStyleDirectory,
+               global $IP, $wgMemc, $wgUser, $wgLang, $wgOut, $wgRequest, $wgStyleDirectory,
                        $wgParserCacheType, $wgNamespaceAliases, $wgNamespaceProtection;
 
                $tmpDir = $this->getNewTempDirectory();
@@ -60,7 +60,6 @@ class UploadFromUrlTestSuite extends PHPUnit_Framework_TestSuite {
                $wgParserCacheType = CACHE_NONE;
                DeferredUpdates::clearPendingUpdates();
                $wgMemc = ObjectCache::getLocalClusterInstance();
-               $messageMemc = wfGetMessageCacheStorage();
 
                RequestContext::resetMain();
                $context = RequestContext::getMain();