selenium: RecentChanges page object

Return DOM element(s) to specs instead of creating another level of
inflection and to be more in line with other implementations.
Follow-up for I916516d5055c3ce9be071a75e5c3af2b3547d4ba

Bug: T191600
Change-Id: I03b0cd4af7adca23dd34173710b995629f833a1a

diff --git a/tests/selenium/pageobjects/recentchanges.page.js b/tests/selenium/pageobjects/recentchanges.page.js
index 02d3843..edecc91 100644 (file)
--- a/tests/selenium/pageobjects/recentchanges.page.js
+++ b/tests/selenium/pageobjects/recentchanges.page.js
@@ -2,12 +2,7 @@ const Page = require( 'wdio-mediawiki/Page' );
 
 class RecentChangesPage extends Page {
        get changesList() { return browser.element( '.mw-changeslist' ); }
-       get changesListTitles() { return this.changesList.$$( '.mw-changeslist-title' ); }
-       get titles() {
-               return this.changesListTitles.map( function ( element ) {
-                       return element.getText();
-               } );
-       }
+       get titles() { return this.changesList.$$( '.mw-changeslist-title' ); }
 
        open() {
                super.openTitle( 'Special:RecentChanges' );

diff --git a/tests/selenium/specs/specialrecentchanges.js b/tests/selenium/specs/specialrecentchanges.js
index 418fbb1..d82f78f 100644 (file)
--- a/tests/selenium/specs/specialrecentchanges.js
+++ b/tests/selenium/specs/specialrecentchanges.js
@@ -23,7 +23,7 @@ describe( 'Special:RecentChanges', function () {
 
                RecentChangesPage.open();
 
-               assert.strictEqual( name, RecentChangesPage.titles[ 0 ] );
+               assert.strictEqual( RecentChangesPage.titles[ 0 ].getText(), name );
        } );
 
 } );