Fixed Style/PerlBackrefs RuboCop offense

Refactored to use `Regexp#match`, avoiding use of match globals
entirely.

Bug: T91485
Change-Id: I4b1a40e153c18d92ef9e78291bc4e14781cc6978

diff --git a/.rubocop.yml b/.rubocop.yml
index 3f1af39..8b0f91a 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,13 +1,11 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-    Exclude:
-        - 'extensions/**/*'
-        - 'skins/**/*'
-        - 'tests/frontend/node_modules/**/*'
-        - 'vendor/**/*'
-
-AllCops:
+  Exclude:
+    - 'extensions/**/*'
+    - 'skins/**/*'
+    - 'tests/frontend/node_modules/**/*'
+    - 'vendor/**/*'
   StyleGuideCopsOnly: true
 
 Metrics/LineLength:

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 6c84b52..97ef233 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -11,11 +11,6 @@
 Style/HashSyntax:
   Enabled: false
 
-# Offense count: 4
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Enabled: false
-
 # Offense count: 81
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.

diff --git a/maintenance/jsduck/custom_tags.rb b/maintenance/jsduck/custom_tags.rb
index 9130227..a1f37e4 100644 (file)
--- a/maintenance/jsduck/custom_tags.rb
+++ b/maintenance/jsduck/custom_tags.rb
@@ -72,9 +72,11 @@ class SeeTag < CommonTag
   end
 
   def render_long_see(tag, formatter, position)
-    if tag =~ /\A([^\s]+)( .*)?\Z/m
-      name = $1
-      doc = $2 ? ': ' + $2 : ''
+    match = /\A([^\s]+)( .*)?\Z/m.match(tag)
+
+    if match
+      name = match[1]
+      doc = match[2] ? ': ' + match[2] : ''
       return formatter.format("{@link #{name}} #{doc}")
     else
       JsDuck::Logger.warn(nil, 'Unexpected @see argument: "' + tag + '"', position)
@@ -105,8 +107,10 @@ class ContextTag < CommonTag
   end
 
   def render_long_context(tag, formatter, position)
-    if tag =~ /\A([^\s]+)/m
-      name = $1
+    match = /\A([^\s]+)/m.match(tag)
+
+    if match
+      name = match[1]
       return formatter.format("`context` : {@link #{name}}")
     else
       JsDuck::Logger.warn(nil, 'Unexpected @context argument: "' + tag + '"', position)