Remove return by reference in Title::makeTitle

This made sense back in php4, but has no useful effect anymore
with our minimum php version being 5.5. This also has the effect
of searching for 'function makeTitle' now actually finding something.

Change-Id: I0ea02a2e7dff285341b0e5b5b7773da78bfaaff3

diff --git a/includes/Title.php b/includes/Title.php
index 8aa8cb7..ea42768 100644 (file)
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -500,7 +500,7 @@ class Title implements LinkTarget {
         * @param string $interwiki The interwiki prefix
         * @return Title The new object
         */
-       public static function &makeTitle( $ns, $title, $fragment = '', $interwiki = '' ) {
+       public static function makeTitle( $ns, $title, $fragment = '', $interwiki = '' ) {
                $t = new Title();
                $t->mInterwiki = $interwiki;
                $t->mFragment = $fragment;