Merge "SpecialPageFactory::getPage can return null"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 29 Jun 2017 22:33:46 +0000 (22:33 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 29 Jun 2017 22:33:47 +0000 (22:33 +0000)
includes/specialpage/SpecialPageFactory.php

index 81e2b7e..88336dd 100644 (file)
@@ -459,7 +459,7 @@ class SpecialPageFactory {
                $pages = [];
                foreach ( self::getPageList() as $name => $rec ) {
                        $page = self::getPage( $name );
-                       if ( $page->isListed() && !$page->isRestricted() ) {
+                       if ( $page && $page->isListed() && !$page->isRestricted() ) {
                                $pages[$name] = $page;
                        }
                }
@@ -482,8 +482,8 @@ class SpecialPageFactory {
                }
                foreach ( self::getPageList() as $name => $rec ) {
                        $page = self::getPage( $name );
-                       if (
-                               $page->isListed()
+                       if ( $page
+                               && $page->isListed()
                                && $page->isRestricted()
                                && $page->userCanExecute( $user )
                        ) {