Make User::isBot() also check the "bot" right for sanity

Change-Id: I835cc23719c1975bb86f642d3ede36c882ce2e9b

diff --git a/includes/user/User.php b/includes/user/User.php
index 3d7d71c..b62d252 100644 (file)
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -3403,12 +3403,14 @@ class User implements IDBAccessObject {
         * @since 1.28
         */
        public function isBot() {
-               $isBot = false;
-               if ( !Hooks::run( "UserIsBot", [ $this, &$isBot ] ) ) {
-                       return $isBot;
+               if ( in_array( 'bot', $this->getGroups() ) && $this->isAllowed( 'bot' ) ) {
+                       return true;
                }
 
-               return ( $isBot || in_array( 'bot', $this->getGroups() ) );
+               $isBot = false;
+               Hooks::run( "UserIsBot", [ $this, &$isBot ] );
+
+               return $isBot;
        }
 
        /**