mediawiki.special.preferences.js: Simplify modulo
authorFomafix <fomafix@googlemail.com>
Fri, 20 Feb 2015 12:02:59 +0000 (12:02 +0000)
committer[[mw:User:Fomafix]] <gerritpatchuploader@gmail.com>
Fri, 20 Feb 2015 12:02:59 +0000 (12:02 +0000)
See:
https://stackoverflow.com/questions/4467539/javascript-modulo-not-behaving

Change-Id: Id3efc7c7a1a57dcbb33ba1272ed5a20428ee6433

resources/src/mediawiki.special/mediawiki.special.preferences.js

index 2e660ce..6ea7501 100644 (file)
@@ -223,12 +223,8 @@ jQuery( function ( $ ) {
                localTime = servertime + minuteDiff;
 
                // Bring time within the [0,1440) range.
-               while ( localTime < 0 ) {
-                       localTime += 1440;
-               }
-               while ( localTime >= 1440 ) {
-                       localTime -= 1440;
-               }
+               localTime = ( ( localTime % 1440 ) + 1440 ) % 1440;
+
                $localtimeHolder.text( mediaWiki.language.convertNumber( minutesToHours( localTime ) ) );
        }