Live preview: Don't show empty summary preview
authorDerk-Jan Hartman <hartman.wiki@gmail.com>
Wed, 10 Jun 2015 23:50:25 +0000 (01:50 +0200)
committerDerk-Jan Hartman <hartman.wiki@gmail.com>
Wed, 10 Jun 2015 23:59:43 +0000 (01:59 +0200)
Change-Id: I4334d02cb460fd0f995ba16f1170dd8500744692

resources/src/mediawiki.action/mediawiki.action.edit.preview.js

index 6026a8c..5f1058f 100644 (file)
                }
                request.done( function ( response ) {
                        var isSubject = ( section === 'new' ),
-                               summaryMsg = isSubject ? 'subject-preview' : 'summary-preview';
-                       if ( response.parse.parsedsummary ) {
-                               $editform.find( '.mw-summary-preview' )
-                                       .empty()
-                                       .append(
-                                               mw.message( summaryMsg ).parse(),
-                                               ' ',
-                                               $( '<span>' ).addClass( 'comment' ).html(
-                                                       // There is no equivalent to rawParams
-                                                       mw.message( 'parentheses' ).escaped()
-                                                               .replace( '$1', response.parse.parsedsummary['*'] )
-                                               )
-                                       );
+                               summaryMsg = isSubject ? 'subject-preview' : 'summary-preview',
+                               $summaryPreview = $editform.find( '.mw-summary-preview' ).empty();
+                       if ( response.parse.parsedsummary && response.parse.parsedsummary['*'] !== '' ) {
+                               $summaryPreview.append(
+                                       mw.message( summaryMsg ).parse(),
+                                       ' ',
+                                       $( '<span>' ).addClass( 'comment' ).html(
+                                               // There is no equivalent to rawParams
+                                               mw.message( 'parentheses' ).escaped()
+                                                       .replace( '$1', response.parse.parsedsummary['*'] )
+                                       )
+                               );
                        }
                        mw.hook( 'wikipage.editform' ).fire( $editform );
                } );