Follow-up Ia16e19985: Fix table sort arrow direction
authorEd Sanders <esanders@wikimedia.org>
Sun, 13 Mar 2016 13:09:51 +0000 (13:09 +0000)
committerEd Sanders <esanders@wikimedia.org>
Mon, 14 Mar 2016 11:51:43 +0000 (11:51 +0000)
In Ia16e19985 we accidentally fixed the down arrow being
'sort_up', but by not switches the class order we changed
the meaning of the up and down arrows.

An up arrow should be labelled as 'up' but show when the
table is in ascending order (smallest at the top).

Bug: T129775
Change-Id: Ia30d4a26728dd0fe93939d746ce9bf9e90742de6

resources/src/jquery/jquery.tablesorter.js

index 2318b33..50bfa87 100644 (file)
                                        $.data( table, 'tablesorter', { config: config } );
 
                                        // Get the CSS class names, could be done elsewhere
-                                       sortCSS = [ config.cssDesc, config.cssAsc ];
+                                       sortCSS = [ config.cssAsc, config.cssDesc ];
+                                       // Messages tell the the user what the *next* state will be
+                                       // so are in reverse order to the CSS classes.
                                        sortMsg = [ mw.msg( 'sort-descending' ), mw.msg( 'sort-ascending' ) ];
 
                                        // Build headers