Advise extensions not to modify $wgWhitelistRead
authorKunal Mehta <legoktm@member.fsf.org>
Wed, 12 Jul 2017 01:30:33 +0000 (18:30 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Wed, 12 Jul 2017 01:30:33 +0000 (18:30 -0700)
Instead they should use the TitleReadWhitelist hook. I've seen this
pattern in multiple extensions now, each causing different problems, so
it should be explicitly documented.

Change-Id: I670b0acde660bdc27a6c7e91c4b1b3baeea8b2e5

includes/DefaultSettings.php

index 11f08b2..6ce9a66 100644 (file)
@@ -5027,6 +5027,9 @@ $wgBlockDisablesLogin = false;
  * @note Also that this will only protect _pages in the wiki_. Uploaded files
  * will remain readable. You can use img_auth.php to protect uploaded files,
  * see https://www.mediawiki.org/wiki/Manual:Image_Authorization
+ *
+ * @note Extensions should not modify this, but use the TitleReadWhitelist
+ * hook instead.
  */
 $wgWhitelistRead = false;