Remove use of implicitGroupby() in WikiPage
authorAaron Schulz <aschulz@wikimedia.org>
Sat, 9 Sep 2017 20:57:35 +0000 (13:57 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 19 Sep 2017 09:17:30 +0000 (09:17 +0000)
Change-Id: I17cc3ae5a6e90ba49978606e9ca6a1cdcdb57c03

includes/page/WikiPage.php

index bf8a597..29ee533 100644 (file)
@@ -982,18 +982,12 @@ class WikiPage implements Page, IDBAccessObject {
 
                $dbr = wfGetDB( DB_REPLICA );
 
-               if ( $dbr->implicitGroupby() ) {
-                       $realNameField = 'user_real_name';
-               } else {
-                       $realNameField = 'MIN(user_real_name) AS user_real_name';
-               }
-
                $tables = [ 'revision', 'user' ];
 
                $fields = [
                        'user_id' => 'rev_user',
                        'user_name' => 'rev_user_text',
-                       $realNameField,
+                       'user_real_name' => 'MIN(user_real_name)',
                        'timestamp' => 'MAX(rev_timestamp)',
                ];