Improve StaticArrayWriterTest and add missing @covers tag

Checking for proper quoting was suggested by Krinkle in CR.

Change-Id: I7fa599767017a5cfc82899bc4178de6cb34bdd02

diff --git a/tests/phpunit/includes/libs/StaticArrayWriterTest.php b/tests/phpunit/includes/libs/StaticArrayWriterTest.php
index bfb3b58..276fee3 100644 (file)
--- a/tests/phpunit/includes/libs/StaticArrayWriterTest.php
+++ b/tests/phpunit/includes/libs/StaticArrayWriterTest.php
@@ -20,11 +20,15 @@
 
 use Wikimedia\StaticArrayWriter;
 
+/**
+ * @covers \Wikimedia\StaticArrayWriter
+ */
 class StaticArrayWriterTest extends PHPUnit\Framework\TestCase {
        public function testCreate() {
                $data = [
                        'foo' => 'bar',
                        'baz' => 'rawr',
+                       "they're" => '"quoted properly"',
                ];
                $writer = new StaticArrayWriter();
                $actual = $writer->create( $data, "Header\nWith\nNewlines" );
@@ -36,6 +40,7 @@ class StaticArrayWriterTest extends PHPUnit\Framework\TestCase {
 return [
        'foo' => 'bar',
        'baz' => 'rawr',
+       'they\'re' => '"quoted properly"',
 ];
 
 PHP;