Add @var to class properties to clarify types

Change-Id: Ia6e9eb70c68b5922077c8e5940b436844fa36e25

diff --git a/includes/session/CookieSessionProvider.php b/includes/session/CookieSessionProvider.php
index aaa522a..6ad00ea 100644 (file)
--- a/includes/session/CookieSessionProvider.php
+++ b/includes/session/CookieSessionProvider.php
@@ -35,7 +35,10 @@ use WebRequest;
  */
 class CookieSessionProvider extends SessionProvider {
 
+       /** @var mixed[] */
        protected $params = [];
+
+       /** @var mixed[] */
        protected $cookieOptions = [];
 
        /**

diff --git a/includes/session/ImmutableSessionProviderWithCookie.php b/includes/session/ImmutableSessionProviderWithCookie.php
index 200b913..149bb80 100644 (file)
--- a/includes/session/ImmutableSessionProviderWithCookie.php
+++ b/includes/session/ImmutableSessionProviderWithCookie.php
@@ -41,6 +41,7 @@ abstract class ImmutableSessionProviderWithCookie extends SessionProvider {
 
        /** @var string|null */
        protected $sessionCookieName = null;
+       /** @var mixed[] */
        protected $sessionCookieOptions = [];
 
        /**

diff --git a/includes/session/PHPSessionHandler.php b/includes/session/PHPSessionHandler.php
index 157cc52..f14e0eb 100644 (file)
--- a/includes/session/PHPSessionHandler.php
+++ b/includes/session/PHPSessionHandler.php
@@ -37,6 +37,8 @@ class PHPSessionHandler implements \SessionHandlerInterface {
 
        /** @var bool Whether PHP session handling is enabled */
        protected $enable = false;
+
+       /** @var bool */
        protected $warn = true;
 
        /** @var SessionManager|null */

diff --git a/includes/session/SessionBackend.php b/includes/session/SessionBackend.php
index f3bfb2b..7956e9f 100644 (file)
--- a/includes/session/SessionBackend.php
+++ b/includes/session/SessionBackend.php
@@ -50,15 +50,25 @@ final class SessionBackend {
        /** @var SessionId */
        private $id;
 
+       /** @var bool */
        private $persist = false;
+
+       /** @var bool */
        private $remember = false;
+
+       /** @var bool */
        private $forceHTTPS = false;
 
        /** @var array|null */
        private $data = null;
 
+       /** @var bool */
        private $forcePersist = false;
+
+       /** @var bool */
        private $metaDirty = false;
+
+       /** @var bool */
        private $dataDirty = false;
 
        /** @var string Used to detect subarray modifications */
@@ -76,6 +86,7 @@ final class SessionBackend {
        /** @var User */
        private $user;
 
+       /** @var int */
        private $curIndex = 0;
 
        /** @var WebRequest[] Session requests */
@@ -87,13 +98,21 @@ final class SessionBackend {
        /** @var array|null provider-specified metadata */
        private $providerMetadata = null;
 
+       /** @var int */
        private $expires = 0;
+
+       /** @var int */
        private $loggedOut = 0;
+
+       /** @var int */
        private $delaySave = 0;
 
+       /** @var bool */
        private $usePhpSessionHandling = true;
+       /** @var bool */
        private $checkPHPSessionRecursionGuard = false;
 
+       /** @var bool */
        private $shutdown = false;
 
        /**

diff --git a/includes/session/SessionInfo.php b/includes/session/SessionInfo.php
index 577e03a..a7bbcce 100644 (file)
--- a/includes/session/SessionInfo.php
+++ b/includes/session/SessionInfo.php
@@ -50,10 +50,19 @@ class SessionInfo {
        /** @var UserInfo|null */
        private $userInfo = null;
 
+       /** @var bool */
        private $persisted = false;
+
+       /** @var bool */
        private $remembered = false;
+
+       /** @var bool */
        private $forceHTTPS = false;
+
+       /** @var bool */
        private $idIsSafe = false;
+
+       /** @var bool */
        private $forceUse = false;
 
        /** @var array|null */

diff --git a/includes/session/Token.php b/includes/session/Token.php
index 14d239d..5165506 100644 (file)
--- a/includes/session/Token.php
+++ b/includes/session/Token.php
@@ -34,8 +34,13 @@ class Token {
         * editing from certain broken proxies. */
        const SUFFIX = '+\\';
 
+       /** @var string */
        private $secret = '';
+
+       /** @var string */
        private $salt = '';
+
+       /** @var bool */
        private $new = false;
 
        /**

diff --git a/includes/session/UserInfo.php b/includes/session/UserInfo.php
index c01b9ec..f5145a3 100644 (file)
--- a/includes/session/UserInfo.php
+++ b/includes/session/UserInfo.php
@@ -49,6 +49,7 @@ use User;
  * @since 1.27
  */
 final class UserInfo {
+       /** @var bool */
        private $verified = false;
 
        /** @var User|null */