Merge "rdbms: set the schema in the LBFactory local domain"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 2 Feb 2018 04:25:46 +0000 (04:25 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 2 Feb 2018 04:25:46 +0000 (04:25 +0000)
1  2 
includes/db/MWLBFactory.php
includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php

@@@ -46,7 -46,7 +46,7 @@@ abstract class MWLBFactory 
                $lbConf += [
                        'localDomain' => new DatabaseDomain(
                                $mainConfig->get( 'DBname' ),
-                               null,
+                               $mainConfig->get( 'DBmwschema' ),
                                $mainConfig->get( 'DBprefix' )
                        ),
                        'profiler' => Profiler::instance(),
@@@ -64,7 -64,7 +64,7 @@@
                // When making changes here, remember to also specify MediaWiki-specific options
                // for Database classes in the relevant Installer subclass.
                // Such as MysqlInstaller::openConnection and PostgresInstaller::openConnectionWithParams.
 -              if ( $lbConf['class'] === 'LBFactorySimple' ) {
 +              if ( $lbConf['class'] === Wikimedia\Rdbms\LBFactorySimple::class ) {
                        if ( isset( $lbConf['servers'] ) ) {
                                // Server array is already explicitly configured; leave alone
                        } elseif ( is_array( $mainConfig->get( 'DBservers' ) ) ) {
                        if ( !isset( $lbConf['externalClusters'] ) ) {
                                $lbConf['externalClusters'] = $mainConfig->get( 'ExternalServers' );
                        }
 -              } elseif ( $lbConf['class'] === 'LBFactoryMulti' ) {
 +              } elseif ( $lbConf['class'] === Wikimedia\Rdbms\LBFactoryMulti::class ) {
                        if ( isset( $lbConf['serverTemplate'] ) ) {
                                if ( in_array( $lbConf['serverTemplate']['type'], $typesWithSchema, true ) ) {
                                        $lbConf['serverTemplate']['schema'] = $mainConfig->get( 'DBmwschema' );
@@@ -72,9 -72,9 +72,9 @@@ class LoadBalancerSingle extends LoadBa
                return new static( [ 'connection' => $db ] + $params );
        }
  
-       protected function reallyOpenConnection( array $server, $dbNameOverride ) {
+       protected function reallyOpenConnection( array $server, DatabaseDomain $domainOverride ) {
                return $this->db;
        }
  }
  
 -class_alias( 'Wikimedia\Rdbms\LoadBalancerSingle', 'LoadBalancerSingle' );
 +class_alias( LoadBalancerSingle::class, 'LoadBalancerSingle' );