Rename $isIpUser to $isAnon, in line with convention elsewhere
authorThalia <thalia.e.chan@googlemail.com>
Thu, 25 Apr 2019 12:02:12 +0000 (13:02 +0100)
committerTchanders <thalia.e.chan@googlemail.com>
Fri, 26 Apr 2019 18:10:59 +0000 (18:10 +0000)
Change-Id: I66721f4af5e844c3e18ba35558390563b8424863

includes/Block.php

index 37b9ce5..3f17d84 100644 (file)
@@ -2132,17 +2132,17 @@ class Block {
         * Check if the block should be tracked with a cookie.
         *
         * @since 1.33
-        * @param bool $isIpUser The user is logged out
+        * @param bool $isAnon The user is logged out
         * @return bool The block should be tracked with a cookie
         */
-       public function shouldTrackWithCookie( $isIpUser ) {
+       public function shouldTrackWithCookie( $isAnon ) {
                $config = RequestContext::getMain()->getConfig();
                switch ( $this->getType() ) {
                        case self::TYPE_IP:
                        case self::TYPE_RANGE:
-                               return $isIpUser && $config->get( 'CookieSetOnIpBlock' );
+                               return $isAnon && $config->get( 'CookieSetOnIpBlock' );
                        case self::TYPE_USER:
-                               return !$isIpUser && $config->get( 'CookieSetOnAutoblock' ) && $this->isAutoblocking();
+                               return !$isAnon && $config->get( 'CookieSetOnAutoblock' ) && $this->isAutoblocking();
                        default:
                                return false;
                }