Always set DBO_DEFAULT by default for LBFactory classes for consistency
authorAaron Schulz <aschulz@wikimedia.org>
Mon, 15 Aug 2016 12:14:04 +0000 (05:14 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Mon, 15 Aug 2016 12:14:04 +0000 (05:14 -0700)
Before, only the non $wgDBservers case did this in LBFactorySimple

Change-Id: If1a962663d5e23b2087873f86efe40a1166f96a7

includes/db/loadbalancer/LBFactoryMulti.php
includes/db/loadbalancer/LBFactorySimple.php

index 0f3ca93..4b9cccc 100644 (file)
@@ -364,6 +364,8 @@ class LBFactoryMulti extends LBFactory {
                        }
                        $serverInfo['hostName'] = $serverName;
                        $serverInfo['load'] = $load;
+                       $serverInfo += [ 'flags' => DBO_DEFAULT ];
+
                        $servers[] = $serverInfo;
                }
 
index 14baf2e..3702c8b 100644 (file)
@@ -56,6 +56,7 @@ class LBFactorySimple extends LBFactory {
                                } else {
                                        $server['slave'] = true;
                                }
+                               $server += [ 'flags' => DBO_DEFAULT ];
                        }
                } else {
                        global $wgDBserver, $wgDBuser, $wgDBpassword, $wgDBname, $wgDBtype, $wgDebugDumpSql;