Merge "Type hint against LinkTarget in WatchedItemStore"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 25 Jul 2019 21:23:58 +0000 (21:23 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 25 Jul 2019 21:23:58 +0000 (21:23 +0000)
1  2 
includes/watcheditem/WatchedItemStore.php

@@@ -383,7 -383,7 +383,7 @@@ class WatchedItemStore implements Watch
  
        /**
         * @param UserIdentity $user
-        * @param TitleValue[] $titles
+        * @param LinkTarget[] $titles
         * @return bool
         * @throws MWException
         */
                }
  
                $oldRev = $this->revisionLookup->getRevisionById( $oldid );
 +              if ( !$oldRev ) {
 +                      // Oldid given but does not exist (probably deleted)
 +                      return false;
 +              }
 +
                $nextRev = $this->revisionLookup->getNextRevision( $oldRev );
                if ( !$nextRev ) {
                        // Oldid given and is the latest revision for this title; clear the timestamp.