Sort allowed log actions when displaying
authorMatěj Suchánek <matejsuchanek97@gmail.com>
Thu, 2 Aug 2018 10:02:02 +0000 (12:02 +0200)
committerMatěj Suchánek <matejsuchanek97@gmail.com>
Thu, 18 Oct 2018 16:20:48 +0000 (18:20 +0200)
This makes searching in the dropdown on Special:ApiSandbox simpler
because it keeps actions of the same log type together.

Change-Id: I240f5e19938393d5c15a1f5e7dd27780957231c0

includes/api/ApiQueryLogEvents.php

index 2d95cd3..3cb55e4 100644 (file)
@@ -388,6 +388,12 @@ class ApiQueryLogEvents extends ApiQueryBase {
 
        public function getAllowedParams( $flags = 0 ) {
                $config = $this->getConfig();
+               if ( $flags & ApiBase::GET_VALUES_FOR_HELP ) {
+                       $logActions = $this->getAllowedLogActions();
+                       sort( $logActions );
+               } else {
+                       $logActions = null;
+               }
                $ret = [
                        'prop' => [
                                ApiBase::PARAM_ISMULTI => true,
@@ -411,9 +417,7 @@ class ApiQueryLogEvents extends ApiQueryBase {
                        ],
                        'action' => [
                                // validation on request is done in execute()
-                               ApiBase::PARAM_TYPE => ( $flags & ApiBase::GET_VALUES_FOR_HELP )
-                                       ? $this->getAllowedLogActions()
-                                       : null
+                               ApiBase::PARAM_TYPE => $logActions
                        ],
                        'start' => [
                                ApiBase::PARAM_TYPE => 'timestamp'