Title: Don't create mSubpages member variable

This variable is set and then immediately returned. It's never read
from, so it doesn't make sense as a member variable.

Change-Id: I507895c32b754b8606fb162db321294d31ab6d4e

diff --git a/includes/Title.php b/includes/Title.php
index 083a725..0728065 100644 (file)
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3172,7 +3172,7 @@ class Title implements LinkTarget {
                if ( $limit > -1 ) {
                        $options['LIMIT'] = $limit;
                }
                if ( $limit > -1 ) {
                        $options['LIMIT'] = $limit;
                }

-               $this->mSubpages = TitleArray::newFromResult(
+               return TitleArray::newFromResult(

                        $dbr->select( 'page',
                                [ 'page_id', 'page_namespace', 'page_title', 'page_is_redirect' ],
                                $conds,
                        $dbr->select( 'page',
                                [ 'page_id', 'page_namespace', 'page_title', 'page_is_redirect' ],
                                $conds,


@@ -3180,7 +3180,6 @@ class Title implements LinkTarget {
                                $options
                        )
                );
                                $options
                        )
                );

-               return $this->mSubpages;

        }
 
        /**
        }
 
        /**