when getting file (img) properties, suppress whines that it's not xml
authorAriel T. Glenn <ariel@wikimedia.org>
Thu, 13 Jun 2019 14:18:58 +0000 (17:18 +0300)
committerReedy <reedy@wikimedia.org>
Mon, 11 Nov 2019 00:32:19 +0000 (00:32 +0000)
Imports eventually succeed but the log fills up with stack traces
needlessly.

Bug: T206013
Change-Id: Icb004954272ea8fc6fbc4fd5090cd1310d66946c
(cherry picked from commit c9a05a70433ca420a52dd86eefd4feb4529d7e49)

includes/libs/mime/MimeAnalyzer.php

index 8d842cb..d6c87b6 100644 (file)
@@ -760,7 +760,9 @@ EOT;
                /**
                 * look for XML formats (XHTML and SVG)
                 */
+               Wikimedia\suppressWarnings();
                $xml = new XmlTypeCheck( $file );
+               Wikimedia\restoreWarnings();
                if ( $xml->wellFormed ) {
                        $xmlTypes = $this->xmlTypes;
                        if ( isset( $xmlTypes[$xml->getRootElement()] ) ) {