dépôts / lhc / web / wiklou.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: ba3fd81)
Revert r42257 "Convert literal tabs to 	 when passing them through Tidy, to preven...
authorAryeh Gregor <simetrical@users.mediawiki.org>
Mon, 29 Nov 2010 00:10:59 +0000 (00:10 +0000)
committerAryeh Gregor <simetrical@users.mediawiki.org>
Mon, 29 Nov 2010 00:10:59 +0000 (00:10 +0000)
This caused bug 16108, and also broke the patch to bug 3276.  The commit
doesn't explain why it's useful or what it fixes, although Platonides
asked on Code Review in 2008, so that's two problems it's caused with no
benefits I've seen.

includes/parser/Tidy.php patch | blob | history

diff --git a/includes/parser/Tidy.php b/includes/parser/Tidy.php
index 3e436c8..49f5d0b 100644 (file)
--- a/includes/parser/Tidy.php
+++ b/includes/parser/Tidy.php
@@ -31,9 +31,6 @@ class MWTidy {
 ' "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html>'.
 '<head><title>test</title></head><body>'.$text.'</body></html>';
 
-               # Tidy is known to clobber tabs; convert them to entities
-               $wrappedtext = str_replace( "\t", '&#9;', $wrappedtext );
-
                if( $wgTidyInternal ) {
                        $correctedtext = self::execInternalTidy( $wrappedtext );
                } else {
@@ -44,9 +41,6 @@ class MWTidy {
                        return $text . "\n<!-- Tidy found serious XHTML errors -->\n";
                }
 
-               # Convert the tabs back from entities
-               $correctedtext = str_replace( '&#9;', "\t", $correctedtext );
-
                return $correctedtext;
        }
 
Wiklou, le Wiki du Wiklou