resourceloader: Avoid global window.mwTestFooJsCounter in unit tests
authorFomafix <fomafix@googlemail.com>
Sun, 24 Feb 2019 09:08:49 +0000 (10:08 +0100)
committerKrinkle <krinklemail@gmail.com>
Fri, 12 Apr 2019 15:25:58 +0000 (15:25 +0000)
This change avoids a failure when running Special:JavaScriptTest with
the option noglobals.

Change-Id: Id61fca5ccedbd793f7786ad95681eaebb9feafb6

tests/qunit/suites/resources/mediawiki/mediawiki.loader.test.js

index 8b3427f..ed1288b 100644 (file)
 
        QUnit.test( '.implement( package files )', function ( assert ) {
                var done = assert.async(),
-                       initJsRan = false;
+                       initJsRan = false,
+                       counter = 41;
                mw.loader.implement(
                        'test.implement.packageFiles',
                        {
                                files: {
                                        'resources/src/foo/data/hello.json': { hello: 'world' },
                                        'resources/src/foo/foo.js': function ( require, module ) {
-                                               window.mwTestFooJsCounter = window.mwTestFooJsCounter || 41;
-                                               window.mwTestFooJsCounter++;
-                                               module.exports = { answer: window.mwTestFooJsCounter };
+                                               counter++;
+                                               module.exports = { answer: counter };
                                        },
                                        'resources/src/bar/bar.js': function ( require, module ) {
                                                var core = require( './core.js' );