deleteLogFormatter: explicitly declare parsedParametersDeleteLog
authorDaimona Eaytoy <daimona.wiki@gmail.com>
Wed, 11 Sep 2019 09:14:34 +0000 (11:14 +0200)
committerDaimona Eaytoy <daimona.wiki@gmail.com>
Fri, 13 Sep 2019 17:55:34 +0000 (17:55 +0000)
Instead of having a dynamic property checked via isset().

Change-Id: I64e3a3135b898b65e789aa8307ab9e3ffa0e9f4a

includes/logging/DeleteLogFormatter.php

index 3bc19ff..e8c4393 100644 (file)
@@ -31,6 +31,12 @@ use MediaWiki\Storage\RevisionRecord;
  * @since 1.19
  */
 class DeleteLogFormatter extends LogFormatter {
  * @since 1.19
  */
 class DeleteLogFormatter extends LogFormatter {
+       /** @var array|null */
+       private $parsedParametersDeleteLog;
+
+       /**
+        * @inheritDoc
+        */
        protected function getMessageKey() {
                $key = parent::getMessageKey();
                if ( in_array( $this->entry->getSubtype(), [ 'event', 'revision' ] ) ) {
        protected function getMessageKey() {
                $key = parent::getMessageKey();
                if ( in_array( $this->entry->getSubtype(), [ 'event', 'revision' ] ) ) {
@@ -50,8 +56,11 @@ class DeleteLogFormatter extends LogFormatter {
                return $key;
        }
 
                return $key;
        }
 
+       /**
+        * @inheritDoc
+        */
        protected function getMessageParameters() {
        protected function getMessageParameters() {
-               if ( isset( $this->parsedParametersDeleteLog ) ) {
+               if ( $this->parsedParametersDeleteLog !== null ) {
                        return $this->parsedParametersDeleteLog;
                }
 
                        return $this->parsedParametersDeleteLog;
                }