Exception renderer: Remove useless check for isCommandLine()
authorChad Horohoe <chadh@wikimedia.org>
Mon, 21 Nov 2016 21:47:09 +0000 (13:47 -0800)
committerChad Horohoe <chadh@wikimedia.org>
Mon, 21 Nov 2016 21:47:09 +0000 (13:47 -0800)
If we're on the cli, we would've never hit this else block

Change-Id: Idff009ab255b1907f752e0c6b5652715923b0ed7

includes/exception/MWExceptionRenderer.php

index 8fdc417..f713115 100644 (file)
@@ -74,11 +74,7 @@ class MWExceptionRenderer {
                                        $message = MWExceptionHandler::getPublicLogMessage( $e );
                                }
                        }
-                       if ( self::isCommandLine() ) {
-                               self::printError( $message );
-                       } else {
-                               echo nl2br( htmlspecialchars( $message ) ) . "\n";
-                       }
+                       echo nl2br( htmlspecialchars( $message ) ) . "\n";
                }
        }