Merge "HTMLFormFieldCloner: Don't try to validate hidden fields"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 25 Nov 2016 18:59:02 +0000 (18:59 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 25 Nov 2016 18:59:02 +0000 (18:59 +0000)
1  2 
includes/htmlform/fields/HTMLFormFieldCloner.php

@@@ -224,7 -224,7 +224,7 @@@ class HTMLFormFieldCloner extends HTMLF
                        && $this->mParams['required'] !== false
                        && !$values
                ) {
 -                      return $this->msg( 'htmlform-cloner-required' )->parseAsBlock();
 +                      return $this->msg( 'htmlform-cloner-required' );
                }
  
                if ( isset( $values['nonjs'] ) ) {
                                if ( !array_key_exists( $fieldname, $value ) ) {
                                        continue;
                                }
+                               if ( $field->isHidden( $alldata ) ) {
+                                       continue;
+                               }
                                $ok = $field->validate( $value[$fieldname], $alldata );
                                if ( $ok !== true ) {
                                        return false;