rcfilters: Use default styling for the overlay

The class .oo-ui-defaultOverlay is used by OOUI, and all the skins
already define reasonable font-size and z-index for it, so we can
remove that here.

Keep the existing class .mw-rcfilters-ui-overlay because apparently
`right: 0; left: 0;` is required (that's weird…) and because Minerva
also wants to override it (I221f6c2d637c7d2a843bfc4a2f7cd9877e2a5b12).

Depends-On: I221f6c2d637c7d2a843bfc4a2f7cd9877e2a5b12
Change-Id: I672fdcebbdc586765de2c10f9a9a21796db57cc5

diff --git a/resources/Resources.php b/resources/Resources.php
index 8234e89..1eee348 100644 (file)
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1860,11 +1860,7 @@ return [
                        'styles/mw.rcfilters.ui.FilterTagMultiselectWidgetMobile.less'
                ],
                'skinStyles' => [
-                       'vector' => [
-                               'styles/mw.rcfilters.ui.Overlay.vector.less',
-                       ],
                        'monobook' => [
-                               'styles/mw.rcfilters.ui.Overlay.monobook.less',
                                'styles/mw.rcfilters.ui.CapsuleItemWidget.monobook.less',
                                'styles/mw.rcfilters.ui.FilterMenuOptionWidget.monobook.less',
                        ],

diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.less
index 06840da..c883309 100644 (file)
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.less
@@ -1,8 +1,6 @@
 .mw-rcfilters-ui-overlay {
-       font-size: 0.875em;
        position: absolute;
        top: 0;
        right: 0;
        left: 0;
-       z-index: 1;
 }

diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.monobook.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.monobook.less
deleted file mode 100644 (file)
index fae2b32..0000000
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.monobook.less
+++ /dev/null
@@ -1,3 +0,0 @@
-.mw-rcfilters-ui-overlay {
-       font-size: 1.28em; /* 0.8em / x-small */
-}

diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.vector.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.vector.less
deleted file mode 100644 (file)
index 528707b..0000000
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.Overlay.vector.less
+++ /dev/null
@@ -1,4 +0,0 @@
-// Fix z-index for the overlay in Vector, see T183442
-.mw-rcfilters-ui-overlay {
-       z-index: 101;
-}

diff --git a/resources/src/mediawiki.rcfilters/ui/MainWrapperWidget.js b/resources/src/mediawiki.rcfilters/ui/MainWrapperWidget.js
index 31edb77..85794cd 100644 (file)
--- a/resources/src/mediawiki.rcfilters/ui/MainWrapperWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/MainWrapperWidget.js
@@ -42,7 +42,7 @@ MainWrapperWidget = function MwRcfiltersUiMainWrapperWidget(
        this.$filtersContainer = config.$filtersContainer;
        this.$changesListContainer = config.$changesListContainer;
        this.$formContainer = config.$formContainer;
-       this.$overlay = $( '<div>' ).addClass( 'mw-rcfilters-ui-overlay' );
+       this.$overlay = $( '<div>' ).addClass( 'mw-rcfilters-ui-overlay oo-ui-defaultOverlay' );
        this.$wrapper = config.$wrapper || this.$element;
 
        this.savedLinksListWidget = new SavedLinksListWidget(