placeholder-message for html form should be ->text() not ->parse()
authorBrian Wolff <bawolff+wn@gmail.com>
Thu, 7 Dec 2017 01:42:24 +0000 (01:42 +0000)
committerBrian Wolff <bawolff+wn@gmail.com>
Thu, 7 Dec 2017 01:42:24 +0000 (01:42 +0000)
placeholder is an html attribute, it does not support arbitrary
html, so ->text() is most appropriate, not full parse.

Follow up d3cd609e

Change-Id: Ia2aa5a001e19ee90e99936ef4f0dc879f182999f

includes/htmlform/fields/HTMLTextAreaField.php
includes/htmlform/fields/HTMLTextField.php

index e6963d5..466a251 100644 (file)
@@ -16,7 +16,7 @@ class HTMLTextAreaField extends HTMLFormField {
                parent::__construct( $params );
 
                if ( isset( $params['placeholder-message'] ) ) {
-                       $this->mPlaceholder = $this->getMessage( $params['placeholder-message'] )->parse();
+                       $this->mPlaceholder = $this->getMessage( $params['placeholder-message'] )->text();
                } elseif ( isset( $params['placeholder'] ) ) {
                        $this->mPlaceholder = $params['placeholder'];
                }
index 1c5a43d..b2e4f2a 100644 (file)
@@ -31,7 +31,7 @@ class HTMLTextField extends HTMLFormField {
                parent::__construct( $params );
 
                if ( isset( $params['placeholder-message'] ) ) {
-                       $this->mPlaceholder = $this->getMessage( $params['placeholder-message'] )->parse();
+                       $this->mPlaceholder = $this->getMessage( $params['placeholder-message'] )->text();
                } elseif ( isset( $params['placeholder'] ) ) {
                        $this->mPlaceholder = $params['placeholder'];
                }