resourceloader: Remove unused string[] module logic in register()
authorTimo Tijhof <krinklemail@gmail.com>
Tue, 4 Sep 2018 01:05:00 +0000 (02:05 +0100)
committerTimo Tijhof <krinklemail@gmail.com>
Tue, 4 Sep 2018 01:17:08 +0000 (02:17 +0100)
There are two signatures for this method that we test, document,
and use:

1. register( name, version, ... )

2. register( [ [name,version,...], [name,version,..], ... ] )

But the code was also allowing a third kind that is never used,
and also not documented anywhere or tested.

3. register( [ name, name, ... ] )

Change-Id: I3ed69117affd83d03c4c629d352f19bad50395c9

resources/src/startup/mediawiki.js

index f927aad..2f196de 100644 (file)
                                        // Allow multiple registration
                                        if ( typeof module === 'object' ) {
                                                resolveIndexedDependencies( module );
+                                               // module is an array of arrays
                                                for ( i = 0; i < module.length; i++ ) {
                                                        // module is an array of module names
-                                                       if ( typeof module[ i ] === 'string' ) {
-                                                               mw.loader.register( module[ i ] );
-                                                       // module is an array of arrays
-                                                       } else if ( typeof module[ i ] === 'object' ) {
-                                                               mw.loader.register.apply( mw.loader, module[ i ] );
-                                                       }
+                                                       mw.loader.register.apply( mw.loader, module[ i ] );
                                                }
                                                return;
                                        }