Use OOUI form for 'clear' and 'raw edit' of watchlist
authorEd Sanders <esanders@wikimedia.org>
Tue, 24 Apr 2018 11:08:45 +0000 (12:08 +0100)
committerEd Sanders <esanders@wikimedia.org>
Mon, 30 Apr 2018 18:06:26 +0000 (19:06 +0100)
Change-Id: I2c53f66bc36b33d42d453b79056822b30796ea4e

includes/specials/SpecialEditWatchlist.php
tests/phpunit/includes/specials/SpecialEditWatchlistTest.php

index f702bc0..5e04d8d 100644 (file)
@@ -667,7 +667,7 @@ class SpecialEditWatchlist extends UnlistedSpecialPage {
                ];
                $context = new DerivativeContext( $this->getContext() );
                $context->setTitle( $this->getPageTitle( 'raw' ) ); // Reset subpage
-               $form = new HTMLForm( $fields, $context );
+               $form = new OOUIHTMLForm( $fields, $context );
                $form->setSubmitTextMsg( 'watchlistedit-raw-submit' );
                # Used message keys: 'accesskey-watchlistedit-raw-submit', 'tooltip-watchlistedit-raw-submit'
                $form->setSubmitTooltip( 'watchlistedit-raw-submit' );
@@ -686,7 +686,7 @@ class SpecialEditWatchlist extends UnlistedSpecialPage {
        protected function getClearForm() {
                $context = new DerivativeContext( $this->getContext() );
                $context->setTitle( $this->getPageTitle( 'clear' ) ); // Reset subpage
-               $form = new HTMLForm( [], $context );
+               $form = new OOUIHTMLForm( [], $context );
                $form->setSubmitTextMsg( 'watchlistedit-clear-submit' );
                # Used message keys: 'accesskey-watchlistedit-clear-submit', 'tooltip-watchlistedit-clear-submit'
                $form->setSubmitTooltip( 'watchlistedit-clear-submit' );
index 05a63db..69fa0dd 100644 (file)
@@ -33,7 +33,7 @@ class SpecialEditWatchlistTest extends SpecialPageTestBase {
                $user = new TestUser( __METHOD__ );
                list( $html, ) = $this->executeSpecialPage( 'clear', null, 'qqx', $user->getUser() );
                $this->assertRegExp(
-                       '/<form class="mw-htmlform" action=".*?Special:EditWatchlist\/clear" method="post">/',
+                       '/<form action=\'.*?Special:EditWatchlist\/clear\'/',
                        $html
                );
        }
@@ -42,7 +42,7 @@ class SpecialEditWatchlistTest extends SpecialPageTestBase {
                $user = new TestUser( __METHOD__ );
                list( $html, ) = $this->executeSpecialPage( 'raw', null, 'qqx', $user->getUser() );
                $this->assertContains(
-                       '<textarea id="mw-input-wpTitles"',
+                       '<div id=\'mw-input-wpTitles\'',
                        $html
                );
        }