RCFilters: Only build tag list when experimental views are enabled
authorRoan Kattouw <roan.kattouw@gmail.com>
Fri, 7 Jul 2017 22:36:13 +0000 (15:36 -0700)
committerKrinkle <krinklemail@gmail.com>
Sat, 8 Jul 2017 02:04:42 +0000 (02:04 +0000)
Follows-up 7725c755867ac1.

It's a waste otherwise, and buildChangeTagList() has perf issues.

Change-Id: Ifd7f81792fd7b5ee6e41ada756abbf0248f3eb36

includes/specials/SpecialRecentchanges.php

index 4f21586..2fe56f9 100644 (file)
@@ -177,6 +177,9 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
                                )
                        );
 
+                       $experimentalStructuredChangeFilters =
+                               $this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' );
+
                        $out->addJsConfigVars( 'wgStructuredChangeFilters', $jsData['groups'] );
                        $out->addJsConfigVars(
                                'wgStructuredChangeFiltersEnableSaving',
@@ -184,16 +187,18 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
                        );
                        $out->addJsConfigVars(
                                'wgStructuredChangeFiltersEnableExperimentalViews',
-                               $this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' )
+                               $experimentalStructuredChangeFilters
                        );
                        $out->addJsConfigVars(
                                'wgStructuredChangeFiltersEnableLiveUpdate',
                                $this->getConfig()->get( 'StructuredChangeFiltersEnableLiveUpdate' )
                        );
-                       $out->addJsConfigVars(
-                               'wgRCFiltersChangeTags',
-                               $this->buildChangeTagList()
-                       );
+                       if ( $experimentalStructuredChangeFilters ) {
+                               $out->addJsConfigVars(
+                                       'wgRCFiltersChangeTags',
+                                       $this->buildChangeTagList()
+                               );
+                       }
                }
        }