Send 500 http status code, instead of 200, for DBConnectionErrors
authorFlorian Schmidt <florian.schmidt.stargatewissen@gmail.com>
Sun, 16 Apr 2017 19:26:13 +0000 (21:26 +0200)
committerFomafix <fomafix@googlemail.com>
Fri, 21 Apr 2017 11:55:36 +0000 (11:55 +0000)
Bug: T160875
Change-Id: I4c909457938a19358dfc4b2aec216b1a148df46c

includes/exception/MWExceptionRenderer.php

index a569bcd..1412adb 100644 (file)
@@ -42,10 +42,10 @@ class MWExceptionRenderer {
                } elseif ( self::isCommandLine() ) {
                        self::printError( self::getText( $e ) );
                } elseif ( $mode === self::AS_PRETTY ) {
+                       self::statusHeader( 500 );
                        if ( $e instanceof DBConnectionError ) {
                                self::reportOutageHTML( $e );
                        } else {
-                               self::statusHeader( 500 );
                                self::header( "Content-Type: $wgMimeType; charset=utf-8" );
                                self::reportHTML( $e );
                        }