mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form

To improve in the future:
* Check the rights on the target wiki rather than current, they might
  not be the same
* Use a better error message when not all logged-in users can upload

Bug: T115866
Change-Id: I6f68122b5399f4b8766825c752e964478ae7563d

diff --git a/resources/Resources.php b/resources/Resources.php
index 59ce155..3a6a3b5 100644 (file)
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1171,6 +1171,7 @@ return array(
                ),
                'dependencies' => array(
                        'oojs-ui',
+                       'mediawiki.user',
                        'mediawiki.Upload',
                        'mediawiki.jqueryMsg',
                ),

diff --git a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
index dd199ce..0a1121b 100644 (file)
--- a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
+++ b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
@@ -88,6 +88,17 @@
                                content: [ this.insertForm ]
                        } )
                ] );
+
+               // If the user can't upload anything, don't give them the option to
+               // TODO Check the rights on the target wiki rather than current, they might not be the same
+               mw.user.getRights().done( function ( rights ) {
+                       if ( rights.indexOf( 'upload' ) === -1 ) {
+                               this.getPage( 'upload' ).$element
+                                       .empty()
+                                       // TODO Use a better error message when not all logged-in users can upload
+                                       .msg( 'api-error-mustbeloggedin' );
+                       }
+               }.bind( this ) );
        };
 
        /* Setup */