Don't suggest using extract()
authorMax Semenik <maxsem.wiki@gmail.com>
Sat, 24 Feb 2018 01:41:20 +0000 (17:41 -0800)
committerMax Semenik <maxsem.wiki@gmail.com>
Sat, 24 Feb 2018 01:41:20 +0000 (17:41 -0800)
Especially for things as trivial as this.

Bug: T28496
Change-Id: Id4bc7f0e6411e943dff45e45964c08d44e6ccb96

includes/libs/rdbms/database/IMaintainableDatabase.php

index 66012da..d0c398e 100644 (file)
@@ -62,8 +62,8 @@ interface IMaintainableDatabase extends IDatabase {
         * This is handy when you need to construct SQL for joins
         *
         * Example:
-        * extract( $dbr->tableNames( 'user', 'watchlist' ) );
-        * $sql = "SELECT wl_namespace,wl_title FROM $watchlist,$user
+        * list( $user, $watchlist ) = $dbr->tableNames( 'user', 'watchlist' ) );
+        * $sql = "SELECT wl_namespace, wl_title FROM $watchlist, $user
         *         WHERE wl_user=user_id AND wl_user=$nameWithQuotes";
         *
         * @return array