Fix registerTempTableOperation() return value for non-temporary table DROPs
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 4 May 2017 20:09:27 +0000 (13:09 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 4 May 2017 20:29:20 +0000 (13:29 -0700)
Change-Id: I338dfbbf5479d5157de8d9abc2012cc0e7d10c93

includes/libs/rdbms/database/Database.php

index 88a883a..3bb7e6a 100644 (file)
@@ -833,9 +833,10 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware
                        $sql,
                        $matches
                ) ) {
+                       $isTemp = isset( $this->mSessionTempTables[$matches[1]] );
                        unset( $this->mSessionTempTables[$matches[1]] );
 
-                       return true;
+                       return $isTemp;
                } elseif ( preg_match(
                        '/^(?:INSERT\s+(?:\w+\s+)?INTO|UPDATE|DELETE\s+FROM)\s+[`"\']?(\w+)[`"\']?/i',
                        $sql,