LoginSignupSpecialPage: Don't output empty 'uselang'
authorBrad Jorsch <bjorsch@wikimedia.org>
Mon, 7 Nov 2016 15:55:00 +0000 (10:55 -0500)
committerBrad Jorsch <bjorsch@wikimedia.org>
Mon, 7 Nov 2016 15:58:31 +0000 (10:58 -0500)
It confuses things because the empty string is accepted as a language,
which falls back to English.

Bug: T146147
Change-Id: Ie56eb95a85a24c5701901abdfb722cebc108bde4

includes/specialpage/LoginSignupSpecialPage.php

index 984e32b..7cdcdea 100644 (file)
@@ -156,7 +156,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
                        [
                                'returnto' => $this->mReturnTo,
                                'returntoquery' => $this->mReturnToQuery,
-                               'uselang' => $this->mLanguage,
+                               'uselang' => $this->mLanguage ?: null,
                                'fromhttp' => $wgSecureLogin && $this->mFromHTTP ? '1' : null,
                        ]
                );
@@ -619,7 +619,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
                $form = HTMLForm::factory( 'vform', $formDescriptor, $context );
 
                $form->addHiddenField( 'authAction', $this->authAction );
-               if ( $wgLoginLanguageSelector ) {
+               if ( $wgLoginLanguageSelector && $this->mLanguage ) {
                        $form->addHiddenField( 'uselang', $this->mLanguage );
                }
                $form->addHiddenField( 'force', $this->securityLevel );