Include IP address in "Login for $1 succeeded" log entry
authorKunal Mehta <legoktm@member.fsf.org>
Sat, 20 Oct 2018 12:35:22 +0000 (05:35 -0700)
committerReedy <reedy@wikimedia.org>
Sat, 20 Oct 2018 13:02:32 +0000 (13:02 +0000)
Bug: T207540
Change-Id: Iab4f2f2ddc8e64ead2f33356d03fa7beed399415

includes/auth/AuthManager.php

index ab7ba0f..c2e6d32 100644 (file)
@@ -681,8 +681,9 @@ class AuthManager implements LoggerAwareInterface {
                        // Step 4: Authentication complete! Set the user in the session and
                        // clean up.
 
                        // Step 4: Authentication complete! Set the user in the session and
                        // clean up.
 
-                       $this->logger->info( 'Login for {user} succeeded', [
+                       $this->logger->info( 'Login for {user} succeeded from {clientip}', [
                                'user' => $user->getName(),
                                'user' => $user->getName(),
+                               'clientip' => $this->request->getIP(),
                        ] );
                        /** @var RememberMeAuthenticationRequest $req */
                        $req = AuthenticationRequest::getRequestByClass(
                        ] );
                        /** @var RememberMeAuthenticationRequest $req */
                        $req = AuthenticationRequest::getRequestByClass(