RCFilters UI: Anchor the highlight popup
authorMoriel Schottlender <moriel@gmail.com>
Wed, 8 Mar 2017 02:22:07 +0000 (18:22 -0800)
committerMoriel Schottlender <moriel@gmail.com>
Wed, 8 Mar 2017 02:23:03 +0000 (18:23 -0800)
Due to a regression in popups positioning in OOUI, the popup
renders wrongly when it is unanchored.

Fixing this to an anchored popup while the OOUI bug is being fixed.

Bug: T159906
Change-Id: I38ca560929f7f9488ff48b148b089f0613d67d97

resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js

index 17aad51..889ba08 100644 (file)
                        icon: 'highlight',
                        indicator: 'down',
                        popup: {
-                               anchor: false,
+                               // TODO: There is a bug in non-anchored popups in
+                               // OOUI, so we set this popup to "anchored" until
+                               // the bug is fixed.
+                               // See: https://phabricator.wikimedia.org/T159906
+                               anchor: true,
                                padded: true,
                                align: 'backwards',
                                horizontalPosition: 'end',