Merge "IcuCollation: Use codepoint as tiebreaker when getting first-letters" into...
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 15 May 2018 23:53:37 +0000 (23:53 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 15 May 2018 23:53:38 +0000 (23:53 +0000)
extensions/MultimediaViewer
includes/installer/Installer.php
includes/utils/ExecutableFinder.php

index 572bff8..1273d3e 160000 (submodule)
@@ -1 +1 @@
-Subproject commit 572bff87f55e7a9fd0618d75de437abe40bd3670
+Subproject commit 1273d3e0b2189e33fed0567f589a3e7bc4ae6d4e
index aa9cd49..4b6e8cc 100644 (file)
@@ -990,6 +990,10 @@ abstract class Installer {
                        return true;
                }
 
+               if ( Shell::isDisabled() ) {
+                       return true;
+               }
+
                # Get a list of available locales.
                $result = Shell::command( '/usr/bin/locale', '-a' )
                        ->execute();
index 9679bfe..78b3f8e 100644 (file)
@@ -94,6 +94,11 @@ class ExecutableFinder {
         * @return bool|string
         */
        public static function findInDefaultPaths( $names, $versionInfo = false ) {
+               if ( Shell::isDisabled() ) {
+                       // If we can't shell out, there's no point looking for executables
+                       return false;
+               }
+
                $paths = self::getPossibleBinPaths();
                foreach ( (array)$names as $name ) {
                        foreach ( $paths as $path ) {