SpecialRecentchanges: Globals for config are bad, m'kay
authorJames D. Forrester <jforrester@wikimedia.org>
Fri, 7 Jul 2017 23:01:17 +0000 (16:01 -0700)
committerJforrester <jforrester@wikimedia.org>
Sat, 8 Jul 2017 00:01:23 +0000 (00:01 +0000)
Change-Id: I9ca7aead42ffee1e891525fc80f3438157f4fb2f

includes/specials/SpecialRecentchanges.php

index bec87c5..05bcc4d 100644 (file)
@@ -138,10 +138,6 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
         * @param string $subpage
         */
        public function execute( $subpage ) {
-               global $wgStructuredChangeFiltersEnableSaving,
-                       $wgStructuredChangeFiltersEnableExperimentalViews,
-                       $wgStructuredChangeFiltersEnableLiveUpdate;
-
                // Backwards-compatibility: redirect to new feed URLs
                $feedFormat = $this->getRequest()->getVal( 'feed' );
                if ( !$this->including() && $feedFormat ) {
@@ -184,15 +180,15 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
                        $out->addJsConfigVars( 'wgStructuredChangeFilters', $jsData['groups'] );
                        $out->addJsConfigVars(
                                'wgStructuredChangeFiltersEnableSaving',
-                               $wgStructuredChangeFiltersEnableSaving
+                               $this->getConfig()->get( 'StructuredChangeFiltersEnableSaving' )
                        );
                        $out->addJsConfigVars(
                                'wgStructuredChangeFiltersEnableExperimentalViews',
-                               $wgStructuredChangeFiltersEnableExperimentalViews
+                               $this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' )
                        );
                        $out->addJsConfigVars(
                                'wgStructuredChangeFiltersEnableLiveUpdate',
-                               $wgStructuredChangeFiltersEnableLiveUpdate
+                               $this->getConfig()->get( 'StructuredChangeFiltersEnableLiveUpdate' )
                        );
                        $out->addJsConfigVars(
                                'wgRCFiltersChangeTags',