thumb.php: Generate valid HTML code on error page
authorFomafix <fomafix@googlemail.com>
Thu, 5 Feb 2015 11:59:34 +0000 (11:59 +0000)
committer[[mw:User:Fomafix]] <gerritpatchuploader@gmail.com>
Thu, 5 Feb 2015 11:59:34 +0000 (11:59 +0000)
http://validator.w3.org/check?uri=https%3A%2F%2Fwww.mediawiki.org%2Fw%2Fthumb.php;No200=1

criticize

Error Line 1, Column 1: no document type declaration; implying "<!DOCTYPE HTML SYSTEM>"

Change-Id: I8dcb6c7f342957ec473fe481aef2011a193ef8a5

thumb.php

index 7352dc4..b49ec19 100644 (file)
--- a/thumb.php
+++ b/thumb.php
@@ -622,7 +622,11 @@ function wfThumbError( $status, $msg ) {
                $debug = '';
        }
        echo <<<EOT
-<html><head><title>Error generating thumbnail</title></head>
+<!DOCTYPE html>
+<html><head>
+<meta charset="UTF-8" />
+<title>Error generating thumbnail</title>
+</head>
 <body>
 <h1>Error generating thumbnail</h1>
 <p>