Remove redundant item loading code in User::createNew
authorAaron Schulz <aschulz@wikimedia.org>
Sat, 24 Feb 2018 00:25:01 +0000 (16:25 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Sat, 24 Feb 2018 00:25:01 +0000 (16:25 -0800)
These lines were removed in 27c61fb1 but left in when I rebased
61b0c193 due to the conflict. The load() call handles all these
fields, so there is no need to set mName and the load state flag.

Change-Id: Id751241abf8d5592309744e96493122c6bc65f2b

includes/user/User.php

index b5106ed..babb571 100644 (file)
@@ -4361,8 +4361,6 @@ class User implements IDBAccessObject, UserIdentity {
                                $newUser = self::newFromId( $dbw->insertId() );
                                // Load the user from master to avoid replica lag
                                $newUser->load( self::READ_LATEST );
-                               $newUser->mName = $fields['user_name'];
-                               $newUser->setItemLoaded( 'name' );
                                $newUser->updateActorId( $dbw );
                        } else {
                                $newUser = null;