SearchResultSet: MW version number should be a string in wfDeprecated call
authorDerick Alangi <alangiderick@gmail.com>
Wed, 15 May 2019 14:17:23 +0000 (15:17 +0100)
committerDerick Alangi <alangiderick@gmail.com>
Wed, 15 May 2019 14:17:23 +0000 (15:17 +0100)
Seems this was a typo and I think 1.32 which is a double/float will be
implicitly converted to true (bool) because it will resolve 1.32 to 1 as
integer and then 1 which maps to true (bool).

To avoid this, use '1.32' instead of the integer form of the version.

Change-Id: Ifaf6ab0d36bc02bd1707f8caf375f65a30eb1af5

includes/search/SearchResultSet.php

index 18331dd..3d3b446 100644 (file)
@@ -84,7 +84,7 @@ class SearchResultSet implements Countable, IteratorAggregate {
                        // This class will eventually be abstract. SearchEngine implementations
                        // already have to extend this class anyways to provide the actual
                        // search results.
-                       wfDeprecated( __METHOD__, 1.32 );
+                       wfDeprecated( __METHOD__, '1.32' );
                }
                $this->containedSyntax = $containedSyntax;
                $this->hasMoreResults = $hasMoreResults;