Give redirects a sort index in title widget
authorEd Sanders <esanders@wikimedia.org>
Sat, 30 Apr 2016 16:23:43 +0000 (17:23 +0100)
committerEd Sanders <esanders@wikimedia.org>
Sat, 30 Apr 2016 16:23:43 +0000 (17:23 +0100)
Otherwise the sort compare function returns NaN
and the order is completely broken.

Bug: T134020
Change-Id: Ie3bbc153e6941d35cfab971690c8934123185d48

resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js

index 3d97711..fdd4a8a 100644 (file)
                                disambiguation: OO.getProp( suggestionPage, 'pageprops', 'disambiguation' ) !== undefined,
                                imageUrl: OO.getProp( suggestionPage, 'thumbnail', 'source' ),
                                description: OO.getProp( suggestionPage, 'terms', 'description' ),
-                               // sort index
+                               // Sort index
                                index: suggestionPage.index
                        };
 
                                        missing: false,
                                        redirect: true,
                                        disambiguation: false,
-                                       description: mw.msg( 'mw-widgets-titleinput-description-redirect', suggestionPage.title )
+                                       description: mw.msg( 'mw-widgets-titleinput-description-redirect', suggestionPage.title ),
+                                       // Sort index, just below its target
+                                       index: suggestionPage.index + 0.5
                                };
                                titles.push( redirects[ i ] );
                        }