re Bug 31007 - rebuildrecentchanges.php fails for Postgresql with strings for integers

Authors: "Max" and Tim Landscheidt

Unquote 'null'

diff --git a/CREDITS b/CREDITS
index 5e568a5..fc3949e 100644 (file)
--- a/CREDITS
+++ b/CREDITS
@@ -131,6 +131,7 @@ following names for their contribution to the product.
 * Mathias Ertl
 * Matthew Britton
 * mati
+* Max
 * Max Sikström
 * merl
 * Michael Dale
@@ -170,6 +171,7 @@ following names for their contribution to the product.
 * Str4nd
 * svip
 * The Evil IP address
+* Tim Landscheidt
 * Tisane
 * Umherirrender
 * Van de Bugger

diff --git a/maintenance/rebuildrecentchanges.php b/maintenance/rebuildrecentchanges.php
index 5cacac6..92d6090 100644 (file)
--- a/maintenance/rebuildrecentchanges.php
+++ b/maintenance/rebuildrecentchanges.php
@@ -119,11 +119,11 @@ class RebuildRecentchanges extends Maintenance {
                                if ( $row ) {
                                        $lastOldId = intval( $row->rev_id );
                                        # Grab the last text size if available
-                                       $lastSize = !is_null( $row->rev_len ) ? intval( $row->rev_len ) : 'NULL';
+                                       $lastSize = !is_null( $row->rev_len ) ? intval( $row->rev_len ) : null;
                                } else {
                                        # No previous edit
                                        $lastOldId = 0;
-                                       $lastSize = 'NULL';
+                                       $lastSize = null;
                                        $new = 1; // probably true
                                }
                        }