FSFile and TempFSFile cleanups
authorAaron Schulz <aschulz@wikimedia.org>
Mon, 19 Sep 2016 00:22:36 +0000 (17:22 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Mon, 19 Sep 2016 19:55:09 +0000 (19:55 +0000)
commitf7e3ac3f95ce2b5a9f73326e854d1c301b513078
treefe70905a0d7b96c6b1fa311808a0790bb6ad55fc
parent95eed85fb9c085cd2da8200335ec16640054e18f
FSFile and TempFSFile cleanups

* Remove wf* function dependencies. This includes wfTempDir().
  Callers now should specify the directory, though it will try to do
  most of the wfTempDir() logic anyway if they do not.
* Update callers to inject wfTempDir() so $wgTmpDirectory is used by
  TempFSFile instead of it probing to find a valid directory itself.
* Move most of the wfTempDir() logic to TempFSFile::getUsableTempDirectory().
* Remove unused getMimeType() method.

Change-Id: Idd55936b07f9448a6c90577708722b7b52b8fe66
includes/GlobalFunctions.php
includes/api/ApiImageRotate.php
includes/filebackend/FSFile.php
includes/filebackend/TempFSFile.php
includes/filerepo/file/File.php
includes/upload/UploadFromChunks.php
includes/upload/UploadFromUrl.php
tests/phpunit/includes/filebackend/FileBackendTest.php
tests/phpunit/includes/filerepo/MigrateFileRepoLayoutTest.php
tests/phpunit/mocks/filebackend/MockFSFile.php